Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2065083002: Revert of [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg, mathias
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. (patchset #3 id:40001 of https://codereview.chromium.org/2059113002/ ) Reason for revert: compile failure Original issue's description: > [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. > > R=littledan@chromium.org, mathias@qiwi.be > BUG=v8:4743 > > Committed: https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4 > Cr-Commit-Position: refs/heads/master@{#36969} TBR=littledan@chromium.org,mathias@qiwi.be # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4743 Committed: https://crrev.com/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37 Cr-Commit-Position: refs/heads/master@{#36970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -119 lines) Patch
M src/regexp/regexp-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/regexp-parser.cc View 9 chunks +19 lines, -46 lines 0 comments Download
M test/mjsunit/harmony/regexp-property-general-category.js View 2 chunks +8 lines, -8 lines 0 comments Download
D test/mjsunit/harmony/regexp-property-lu-ui.js View 1 chunk +0 lines, -13 lines 0 comments Download
D test/mjsunit/harmony/regexp-property-special.js View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}.
4 years, 6 months ago (2016-06-14 13:58:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065083002/1
4 years, 6 months ago (2016-06-14 13:58:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 13:59:04 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 14:02:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fe12ef8fab76dfeeab6b568067bd9be8d8a6b37
Cr-Commit-Position: refs/heads/master@{#36970}

Powered by Google App Engine
This is Rietveld 408576698