Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2065073003:
Revert of Reenable WebGL Image Chromium. (Closed)
|
Created:
4 years, 6 months ago by erikchen Modified:
4 years, 6 months ago CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, f(malita), jam, jbroman, Justin Novosad, Rik, darin-cc_chromium.org, dshwang, blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis, Zhenyao Mo, Jamie Madill Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Reenable WebGL Image Chromium. (patchset #2 id:20001 of https://codereview.chromium.org/2063803002/ )
Reason for revert:
Breaks 2 conformance tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=620067
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%20%28Intel%29/builds/13588
Original issue's description:
> Reenable WebGL Image Chromium.
>
> The feature was disabled because of two bugs. Both have since been fixed.
>
> BUG=617249, 581777
>
> Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8
> Cr-Commit-Position: refs/heads/master@{#399625}
TBR=kbr@chromium.org,piman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617249, 581777
Committed: https://crrev.com/3fb834bc086a1b617db81795475559cc4eb6b524
Cr-Commit-Position: refs/heads/master@{#399813}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
The CQ bit was checked by erikchen@chromium.org
Created Revert of Reenable WebGL Image Chromium.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065073003/1
Sorry for the difficulty. If it's just these two conformance tests just on Mac Intel I'd suggest just suppressing the failures and debugging them later, but if it isn't too much trouble for you to get to the bottom of them before re-landing that would be greatly appreciated.
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065073003/1
On 2016/06/14 21:14:21, Ken Russell wrote: > Sorry for the difficulty. If it's just these two conformance tests just on Mac > Intel I'd suggest just suppressing the failures and debugging them later, but if > it isn't too much trouble for you to get to the bottom of them before re-landing > that would be greatly appreciated. I'm going to be OOO for the rest of the week, and I don't want to leave broken/suppressed tests in the tree for that long. I'll try to debug/reland today.
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
CQ bit was unchecked
On 2016/06/14 21:17:10, erikchen wrote: > On 2016/06/14 21:14:21, Ken Russell wrote: > > Sorry for the difficulty. If it's just these two conformance tests just on Mac > > Intel I'd suggest just suppressing the failures and debugging them later, but > if > > it isn't too much trouble for you to get to the bottom of them before > re-landing > > that would be greatly appreciated. > > I'm going to be OOO for the rest of the week, and I don't want to leave > broken/suppressed tests in the tree for that long. I'll try to debug/reland > today. I've got a fix: https://codereview.chromium.org/2068033002/ If I can't land that today, I'll check the CQ for this CL.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065073003/1
Message was sent while issue was closed.
Description was changed from ========== Revert of Reenable WebGL Image Chromium. (patchset #2 id:20001 of https://codereview.chromium.org/2063803002/ ) Reason for revert: Breaks 2 conformance tests: https://bugs.chromium.org/p/chromium/issues/detail?id=620067 https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%... Original issue's description: > Reenable WebGL Image Chromium. > > The feature was disabled because of two bugs. Both have since been fixed. > > BUG=617249, 581777 > > Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 > Cr-Commit-Position: refs/heads/master@{#399625} TBR=kbr@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617249, 581777 ========== to ========== Revert of Reenable WebGL Image Chromium. (patchset #2 id:20001 of https://codereview.chromium.org/2063803002/ ) Reason for revert: Breaks 2 conformance tests: https://bugs.chromium.org/p/chromium/issues/detail?id=620067 https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%... Original issue's description: > Reenable WebGL Image Chromium. > > The feature was disabled because of two bugs. Both have since been fixed. > > BUG=617249, 581777 > > Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 > Cr-Commit-Position: refs/heads/master@{#399625} TBR=kbr@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617249, 581777 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Revert of Reenable WebGL Image Chromium. (patchset #2 id:20001 of https://codereview.chromium.org/2063803002/ ) Reason for revert: Breaks 2 conformance tests: https://bugs.chromium.org/p/chromium/issues/detail?id=620067 https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%... Original issue's description: > Reenable WebGL Image Chromium. > > The feature was disabled because of two bugs. Both have since been fixed. > > BUG=617249, 581777 > > Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 > Cr-Commit-Position: refs/heads/master@{#399625} TBR=kbr@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617249, 581777 ========== to ========== Revert of Reenable WebGL Image Chromium. (patchset #2 id:20001 of https://codereview.chromium.org/2063803002/ ) Reason for revert: Breaks 2 conformance tests: https://bugs.chromium.org/p/chromium/issues/detail?id=620067 https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%... Original issue's description: > Reenable WebGL Image Chromium. > > The feature was disabled because of two bugs. Both have since been fixed. > > BUG=617249, 581777 > > Committed: https://crrev.com/89f08d55d12c4593a91094c1c0a29ea47fdff6d8 > Cr-Commit-Position: refs/heads/master@{#399625} TBR=kbr@chromium.org,piman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617249, 581777 Committed: https://crrev.com/3fb834bc086a1b617db81795475559cc4eb6b524 Cr-Commit-Position: refs/heads/master@{#399813} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3fb834bc086a1b617db81795475559cc4eb6b524 Cr-Commit-Position: refs/heads/master@{#399813} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
