Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2065063002: [Heap] Fix comparing against new space top pointer (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Heap] Fix comparing against new space top pointer See bug description. BUG=chromium:619382 LOG=N R=ulan@chromium.org Committed: https://crrev.com/d6473f5c14de5f52866b41730807932158fcaffb Cr-Commit-Position: refs/heads/master@{#36968}

Patch Set 1 #

Patch Set 2 : Fix compilation errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -12 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 3 chunks +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-619382.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Michael Lippautz
PTAL
4 years, 6 months ago (2016-06-14 12:57:18 UTC) #3
ulan
lgtm
4 years, 6 months ago (2016-06-14 12:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065063002/1
4 years, 6 months ago (2016-06-14 12:59:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/3139)
4 years, 6 months ago (2016-06-14 13:03:59 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065063002/20001
4 years, 6 months ago (2016-06-14 13:16:48 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 13:43:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065063002/20001
4 years, 6 months ago (2016-06-14 13:48:12 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 13:49:56 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 13:50:02 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 13:52:10 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6473f5c14de5f52866b41730807932158fcaffb
Cr-Commit-Position: refs/heads/master@{#36968}

Powered by Google App Engine
This is Rietveld 408576698