Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2065053003: Revert "Make Safari tests more robust." (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make Safari tests more robust." This reverts commit 199806da039db6dd03a64737a18e0cc97ed5dd0f. That commit failed because tools/bots/compiler.py is being ignored, and test.py is invoked based on recipes not included in this repository. TBR Committed: https://github.com/dart-lang/sdk/commit/b9cdd0e1b2fba6753bd91e2a00347fde556d98aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -508 lines) Patch
M tests/co19/co19-dart2js.status View 6 chunks +5 lines, -35 lines 0 comments Download
M tests/html/html.status View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/bots/compiler.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/safari_factory_reset.py View 1 chunk +0 lines, -27 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 18 chunks +160 lines, -208 lines 0 comments Download
D tools/testing/dart/reset_safari.dart View 1 chunk +0 lines, -227 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
ahe
4 years, 6 months ago (2016-06-15 08:39:21 UTC) #3
ahe
4 years, 6 months ago (2016-06-15 08:39:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9cdd0e1b2fba6753bd91e2a00347fde556d98aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698