Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2065053002: ZoneVector overload of Factory::NewStringFromTwoByte (Closed)

Created:
4 years, 6 months ago by jgruber
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ZoneVector overload of Factory::NewStringFromTwoByte The Vector type is deprecated, and new code should use ZoneVector instead. This new overload of NewStringFromTwoByte will be used in an upcoming regexp CL. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/5c5985b8c7b6624cf9512861235a1223903eef08 Cr-Commit-Position: refs/heads/master@{#36985}

Patch Set 1 #

Patch Set 2 : static_cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M src/factory.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/factory.cc View 1 3 chunks +15 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065053002/1
4 years, 6 months ago (2016-06-14 12:08:42 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/15981)
4 years, 6 months ago (2016-06-14 12:11:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065053002/20001
4 years, 6 months ago (2016-06-14 12:13:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 12:48:18 UTC) #8
jgruber
4 years, 6 months ago (2016-06-14 12:50:45 UTC) #9
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-15 03:34:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065053002/20001
4 years, 6 months ago (2016-06-15 06:41:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 06:42:56 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 06:44:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c5985b8c7b6624cf9512861235a1223903eef08
Cr-Commit-Position: refs/heads/master@{#36985}

Powered by Google App Engine
This is Rietveld 408576698