Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: net/filter/filter_unittest.cc

Issue 206503006: Fix content-encoding handling with buggy servers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Use GetSuggestedFilename Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/filter/filter_unittest.cc
diff --git a/net/filter/filter_unittest.cc b/net/filter/filter_unittest.cc
index 3b912520f82d68a41601cfecaec9fa309357289a..08a2861699ea913c5adacf4c8668385d6fc9ed3e 100644
--- a/net/filter/filter_unittest.cc
+++ b/net/filter/filter_unittest.cc
@@ -82,6 +82,23 @@ TEST(FilterTest, ApacheGzip) {
EXPECT_EQ(Filter::FILTER_TYPE_GZIP, encoding_types.front());
}
+TEST(FilterTest, GzipContentDispositionFilename) {
+ MockFilterContext filter_context;
+ filter_context.SetSdchResponse(false);
+
+ const std::string kGzipMime("application/x-tar");
+ const std::string kContentDisposition("attachment; filename=\"foo.tgz\"");
+ const std::string kURL("http://foo.com/getfoo.php");
+ std::vector<Filter::FilterType> encoding_types;
+
+ encoding_types.push_back(Filter::FILTER_TYPE_GZIP);
+ filter_context.SetMimeType(kGzipMime);
+ filter_context.SetURL(GURL(kURL));
+ filter_context.SetContentDisposition(kContentDisposition);
+ Filter::FixupEncodingTypes(filter_context, &encoding_types);
+ ASSERT_EQ(0U, encoding_types.size());
+}
+
TEST(FilterTest, SdchEncoding) {
// Handle content encodings including SDCH.
const std::string kTextHtmlMime("text/html");

Powered by Google App Engine
This is Rietveld 408576698