Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 206503005: Implements unboxed Mints on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: merge Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 34252)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -365,7 +365,7 @@
XmmRegister result,
Register tmp) {
// Compare upper half.
- Label check_lower, done;
+ Label check_lower;
__ pextrd(tmp, result, Immediate(1));
__ cmpl(tmp, Immediate(0x00200000));
__ j(GREATER, overflow);
@@ -381,8 +381,6 @@
__ j(LESS, overflow);
// Anything in the lower part would make the number bigger than the lower
// bound, so we are done.
-
- __ Bind(&done);
}
@@ -5177,7 +5175,9 @@
summary->set_in(0, needs_writable_input
? Location::WritableRegister()
: Location::RequiresRegister());
- if (needs_temp) summary->set_temp(0, Location::RequiresRegister());
+ if (needs_temp) {
+ summary->set_temp(0, Location::RequiresRegister());
+ }
summary->set_out(0, Location::RequiresFpuRegister());
return summary;
}
@@ -5414,8 +5414,8 @@
ASSERT(locs()->in(1).reg() == ECX);
ASSERT(locs()->out(0).fpu_reg() == left);
- Label* deopt = compiler->AddDeoptStub(deopt_id(),
- kDeoptShiftMintOp);
+ Label* deopt = compiler->AddDeoptStub(deopt_id(),
+ kDeoptShiftMintOp);
Label done;
__ testl(ECX, ECX);
__ j(ZERO, &done); // Shift by 0 is a nop.
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698