Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 206503002: DevTools: Allow general editing of author shadow DOM elements (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
vsevik, aandrey, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Allow general editing of author shadow DOM elements As a drive-by, shadow DOM editing tests have been extracted into a new HTML R=aandrey, pfeldman, vsevik BUG=353910 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -143 lines) Patch
M LayoutTests/inspector/elements/edit-dom-actions.html View 8 chunks +21 lines, -126 lines 0 comments Download
M LayoutTests/inspector/elements/edit-dom-actions-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
A LayoutTests/inspector/elements/edit-dom-actions-shadow.html View 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/edit-dom-actions-shadow-expected.txt View 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/edit-dom-test.js View 1 chunk +81 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
apavlov
6 years, 9 months ago (2014-03-20 14:24:24 UTC) #1
vsevik
lgtm
6 years, 9 months ago (2014-03-21 14:06:12 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-21 14:06:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/206503002/1
6 years, 9 months ago (2014-03-21 14:06:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 15:13:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-21 15:13:59 UTC) #6
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-21 15:15:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/206503002/1
6 years, 9 months ago (2014-03-21 15:15:25 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 15:15:46 UTC) #9
Message was sent while issue was closed.
Change committed as 169743

Powered by Google App Engine
This is Rietveld 408576698