Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2065013002: [heap] Add inlined fast path for JSArrayBuffer (un)register in tracker (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add inlined fast path for JSArrayBuffer (un)register in tracker BUG=chromium:619491, chromium:611688 LOG=N R=ulan@chromium.org Committed: https://crrev.com/5846acc240dd5df71759fefbe9b1ad0bc17f6375 Cr-Commit-Position: refs/heads/master@{#37010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -63 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/array-buffer-tracker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 3 chunks +1 line, -58 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 chunk +68 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Lippautz
PTAl, this get's rid of most of the regression on my machine
4 years, 6 months ago (2016-06-14 08:18:06 UTC) #3
ulan
lgtm
4 years, 6 months ago (2016-06-15 15:58:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065013002/1
4 years, 6 months ago (2016-06-15 16:15:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 16:41:32 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:43:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5846acc240dd5df71759fefbe9b1ad0bc17f6375
Cr-Commit-Position: refs/heads/master@{#37010}

Powered by Google App Engine
This is Rietveld 408576698