Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2064993002: [stubs] Remove the is_jsarray bit from the TransitionElementsKindStub. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove the is_jsarray bit from the TransitionElementsKindStub. There's no need to have different versions of the fairly complex TransitionElementsKindStub just to avoid a single instance type check at execution time (which is used to figure out the effective length in case of JSArray objects). R=ishell@chromium.org Committed: https://crrev.com/46020a2d128a4116a6f563dd75e3653bfef6a8f5 Cr-Commit-Position: refs/heads/master@{#36954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -35 lines) Patch
M src/code-stubs.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +52 lines, -6 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-14 07:24:41 UTC) #1
Benedikt Meurer
Hey Igor, Some simple cleanup (partially in preparation for TurboFan work related to transition elements ...
4 years, 6 months ago (2016-06-14 07:25:20 UTC) #2
Igor Sheludko
lgtm
4 years, 6 months ago (2016-06-14 07:55:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064993002/1
4 years, 6 months ago (2016-06-14 09:28:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 09:33:46 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 09:36:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46020a2d128a4116a6f563dd75e3653bfef6a8f5
Cr-Commit-Position: refs/heads/master@{#36954}

Powered by Google App Engine
This is Rietveld 408576698