Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2064953003:
Disable UndoTabModelTest#testTwoTabs on tablets. (Closed)
DescriptionDisable UndoTabModelTest#testTwoTabs on tablets.
The test is flaking.
BUG=620014
Committed: https://crrev.com/2675c11e7f3c94ef3468a548e1161c48dff35f69
Cr-Commit-Position: refs/heads/master@{#399831}
Patch Set 1 #
Messages
Total messages: 25 (9 generated)
mariakhomenko@chromium.org changed reviewers: + jbudorick@chromium.org
lgtm
On 2016/06/14 22:59:20, jbudorick wrote: > lgtm (not an owner here, though)
The CQ bit was checked by mariakhomenko@chromium.org
On 2016/06/14 22:59:53, jbudorick wrote: > On 2016/06/14 22:59:20, jbudorick wrote: > > lgtm > > (not an owner here, though) (it's ok, I am an owner here)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953003/1
On 2016/06/14 23:05:28, Maria wrote: > On 2016/06/14 22:59:53, jbudorick wrote: > > On 2016/06/14 22:59:20, jbudorick wrote: > > > lgtm > > > > (not an owner here, though) > > (it's ok, I am an owner here) :( I missed your ldap when looking over that file, sorry
On 2016/06/14 23:07:12, jbudorick wrote: > On 2016/06/14 23:05:28, Maria wrote: > > On 2016/06/14 22:59:53, jbudorick wrote: > > > On 2016/06/14 22:59:20, jbudorick wrote: > > > > lgtm > > > > > > (not an owner here, though) > > > > (it's ok, I am an owner here) > > :( I missed your ldap when looking over that file, sorry ... oh, I didn't look at chrome/android/OWNERS, just chrome/android/javatests/OWNERS
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mariakhomenko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mariakhomenko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mariakhomenko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Disable UndoTabModelTest#testTwoTabs on tablets. The test is flaking. BUG=620014 ========== to ========== Disable UndoTabModelTest#testTwoTabs on tablets. The test is flaking. BUG=620014 Committed: https://crrev.com/2675c11e7f3c94ef3468a548e1161c48dff35f69 Cr-Commit-Position: refs/heads/master@{#399831} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2675c11e7f3c94ef3468a548e1161c48dff35f69 Cr-Commit-Position: refs/heads/master@{#399831} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
