Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher.h
diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h
index e07d839c480019efb53c7902820a3fd0d6b219e8..dc4d79684d6dad90c19229c68308b55fae2dd434 100644
--- a/chrome/browser/banners/app_banner_data_fetcher.h
+++ b/chrome/browser/banners/app_banner_data_fetcher.h
@@ -149,7 +149,7 @@ class AppBannerDataFetcher : public base::RefCountedThreadSafe<
void OnDidHasManifest(bool has_manifest);
void OnDidGetManifest(const content::Manifest& manifest);
void OnDidCheckHasServiceWorker(bool has_service_worker);
- void OnAppIconFetched(const SkBitmap& bitmap);
+ void OnAppIconFetched(const GURL& app_icon_url, const SkBitmap& bitmap);
// Called when it is determined that the webapp has fulfilled the initial
// criteria of having a manifest and a service worker.
@@ -164,8 +164,9 @@ class AppBannerDataFetcher : public base::RefCountedThreadSafe<
// heuristic allowed.
void RecordCouldShowBanner();
- // Creates a banner for the app using the given |icon|.
- virtual void ShowBanner(const SkBitmap* icon,
+ // Creates a banner for the app using the given icon.
+ virtual void ShowBanner(const GURL& icon_url,
+ const SkBitmap* icon,
const base::string16& title,
const std::string& referrer) = 0;
@@ -192,6 +193,7 @@ class AppBannerDataFetcher : public base::RefCountedThreadSafe<
const bool is_debug_mode_;
ui::PageTransition transition_type_;
int event_request_id_;
+ GURL app_icon_url_;
std::unique_ptr<SkBitmap> app_icon_;
std::string referrer_;

Powered by Google App Engine
This is Rietveld 408576698