chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc » ('j') | chrome/browser/banners/app_banner_data_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

index 3effb7b6b9a29f0c73c04b811a9d1e83ff2a7b0f..18de5700f25283ca72838fb414c139d8e39ad947 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h

@@ -46,7 +46,9 @@ class AddToHomescreenDialogHelper :

// AddToHomescreenDataFetcher::Observer

void OnUserTitleAvailable(const base::string16& user_title) override;

- void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon) override;

+ void OnDataAvailable(const ShortcutInfo& info,

+ const GURL& icon_url,

+ const SkBitmap& icon) override;

SkBitmap FinalizeLauncherIcon(const SkBitmap& icon,

const GURL& url,

bool* is_generated) override;

@@ -56,7 +58,9 @@ class AddToHomescreenDialogHelper :

// Called only when the AddToHomescreenDataFetcher has retrieved all of the

// data needed to add the shortcut.

- void AddShortcut(const ShortcutInfo& info, const SkBitmap& icon);

+ void AddShortcut(const ShortcutInfo& info,

+ const GURL& icon_url,

+ const SkBitmap& icon);

void RecordAddToHomescreen();