chrome/browser/android/banners/app_banner_infobar_delegate_android.cc - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | chrome/browser/android/shortcut_helper.h » ('j') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

index 8e54002f2cdd6df1e8bb55d75de6b314b1ceb852..f029829a643ad67abe0af73f799d4412f7fe2064 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

@@ -41,10 +41,12 @@ AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(

int event_request_id,

scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher,

const base::string16& app_title,

+ const GURL& app_icon_url,

SkBitmap* app_icon,

const content::Manifest& web_app_data)

: data_fetcher_(data_fetcher),

app_title_(app_title),

+ app_icon_url_(app_icon_url),

app_icon_(app_icon),

event_request_id_(event_request_id),

web_app_data_(web_app_data),

@@ -255,7 +257,7 @@ bool AppBannerInfoBarDelegateAndroid::Accept() {

content::BrowserThread::PostTask(

content::BrowserThread::IO, FROM_HERE,

base::Bind(&ShortcutHelper::AddShortcutInBackgroundWithSkBitmap, info,

- uid, *app_icon_.get(),

+ uid, app_icon_url_, *app_icon_.get(),

data_fetcher_->FetchWebappSplashScreenImageCallback(uid)));

SendBannerAccepted(web_contents, "web");