Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_desktop.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_data_fetcher_desktop.cc
diff --git a/chrome/browser/banners/app_banner_data_fetcher_desktop.cc b/chrome/browser/banners/app_banner_data_fetcher_desktop.cc
index ae69cff578a2aab993dae6847422d1e660c94854..ebe43c5db296aa81622a5fe979d7bd219a0ebc9f 100644
--- a/chrome/browser/banners/app_banner_data_fetcher_desktop.cc
+++ b/chrome/browser/banners/app_banner_data_fetcher_desktop.cc
@@ -41,11 +41,12 @@ bool AppBannerDataFetcherDesktop::IsWebAppInstalled(
browser_context, start_url);
}
-void AppBannerDataFetcherDesktop::ShowBanner(const SkBitmap* icon,
+void AppBannerDataFetcherDesktop::ShowBanner(const GURL& icon_url,
+ const SkBitmap* icon,
const base::string16& title,
const std::string& referrer) {
content::WebContents* web_contents = GetWebContents();
- DCHECK(web_contents && !web_app_data().IsEmpty());
+ DCHECK(web_contents && !manifest().IsEmpty());
Profile* profile =
Profile::FromBrowserContext(web_contents->GetBrowserContext());
@@ -59,7 +60,7 @@ void AppBannerDataFetcherDesktop::ShowBanner(const SkBitmap* icon,
// calls the InfoBarService to show the banner. On desktop, an InfoBar class
// is not required, so the InfoBarService call is made within the delegate.
infobars::InfoBar* infobar = AppBannerInfoBarDelegateDesktop::Create(
- make_scoped_refptr(this), web_contents, web_app_data(),
+ make_scoped_refptr(this), web_contents, manifest(),
bookmark_app_helper_.get(), event_request_id());
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
@@ -81,7 +82,7 @@ void AppBannerDataFetcherDesktop::FinishCreateBookmarkApp(
event_request_id()));
AppBannerSettingsHelper::RecordBannerDismissEvent(
- web_contents, web_app_data().start_url.spec(),
+ web_contents, manifest().start_url.spec(),
AppBannerSettingsHelper::WEB);
} else {
web_contents->GetMainFrame()->Send(
@@ -90,7 +91,7 @@ void AppBannerDataFetcherDesktop::FinishCreateBookmarkApp(
event_request_id(), "web"));
AppBannerSettingsHelper::RecordBannerInstallEvent(
- web_contents, web_app_data().start_url.spec(),
+ web_contents, manifest().start_url.spec(),
AppBannerSettingsHelper::WEB);
}
}
« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher_desktop.h ('k') | chrome/browser/extensions/bookmark_app_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698