Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index 86f4e675ade388190c0be828c527f7de92842950..d02b94576e07aa3f981ee13c89db80f71d8d2554 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -71,7 +71,8 @@ class AddToHomescreenDataFetcher
void OnDidGetWebApplicationInfo(const WebApplicationInfo& web_app_info);
// Called when the Manifest has been parsed, or if no Manifest was found.
- void OnDidGetManifest(const content::Manifest& manifest);
+ void OnDidGetManifest(const GURL& manifest_url,
+ const content::Manifest& manifest);
// Accessors, etc.
void set_weak_observer(Observer* observer) { weak_observer_ = observer; }
@@ -96,10 +97,10 @@ class AddToHomescreenDataFetcher
// Callback run after an attempt to download manifest icon has been made. May
// kick off the download of a favicon if it failed (i.e. the bitmap is empty).
- void OnManifestIconFetched(const SkBitmap& icon);
+ void OnManifestIconFetched(const GURL& icon_url, const SkBitmap& icon);
// Notifies the observer that the shortcut data is all available.
- void NotifyObserver(const SkBitmap& icon, bool is_generated);
+ void NotifyObserver(const SkBitmap& icon);
// Looks up the original, online URL of the site requested. The URL from the
// WebContents may be an offline page or a distilled article which is not
« no previous file with comments | « chrome/browser/android/shortcut_info.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698