chrome/browser/banners/app_banner_data_fetcher.h - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_data_fetcher.cc » ('j') | content/public/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher.h

diff --git a/chrome/browser/banners/app_banner_data_fetcher.h b/chrome/browser/banners/app_banner_data_fetcher.h

index e07d839c480019efb53c7902820a3fd0d6b219e8..83ef5d96a36b27218b233a1b4bc3aa89b0a7554c 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.h

+++ b/chrome/browser/banners/app_banner_data_fetcher.h

@@ -164,8 +164,9 @@ class AppBannerDataFetcher : public base::RefCountedThreadSafe<

// heuristic allowed.

void RecordCouldShowBanner();

- // Creates a banner for the app using the given |icon|.

- virtual void ShowBanner(const SkBitmap* icon,

+ // Creates a banner for the app using the given icon.

+ virtual void ShowBanner(const GURL& icon_url,

+ const SkBitmap* icon,

const base::string16& title,

const std::string& referrer) = 0;

@@ -192,6 +193,7 @@ class AppBannerDataFetcher : public base::RefCountedThreadSafe<

const bool is_debug_mode_;

ui::PageTransition transition_type_;

int event_request_id_;

+ GURL app_icon_url_;

std::unique_ptr<SkBitmap> app_icon_;

std::string referrer_;