chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/shortcut_info.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | content/public/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

index 86f4e675ade388190c0be828c527f7de92842950..ef0616ce18dc5dbbf93667c20b81478ef0ec1ce3 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

@@ -96,10 +96,10 @@ class AddToHomescreenDataFetcher

// Callback run after an attempt to download manifest icon has been made. May

// kick off the download of a favicon if it failed (i.e. the bitmap is empty).

- void OnManifestIconFetched(const SkBitmap& icon);

+ void OnManifestIconFetched(const GURL& icon_url, const SkBitmap& icon);

// Notifies the observer that the shortcut data is all available.

- void NotifyObserver(const SkBitmap& icon, bool is_generated);

+ void NotifyObserver(const SkBitmap& icon);

// Looks up the original, online URL of the site requested. The URL from the

// WebContents may be an offline page or a distilled article which is not