chrome/browser/android/banners/app_banner_data_fetcher_android.cc - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_data_fetcher_android.h ('k') | chrome/browser/android/banners/app_banner_infobar_delegate_android.h » ('j') | content/public/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

index b8dd12d87021e58ccb76f0cfadb1561f97822f81..7941f11db70a08f5e2d7c5fbc13c97924f3a2b1c 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc

@@ -73,7 +73,8 @@ base::Closure AppBannerDataFetcherAndroid::FetchWebappSplashScreenImageCallback(

minimum_splash_image_size_in_dp_, webapp_id);

}

-void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,

+void AppBannerDataFetcherAndroid::ShowBanner(const GURL& icon_url,

+ const SkBitmap* icon,

const base::string16& title,

const std::string& referrer) {

content::WebContents* web_contents = GetWebContents();

@@ -83,7 +84,7 @@ void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,

if (native_app_data_.is_null()) {

std::unique_ptr<AppBannerInfoBarDelegateAndroid> delegate(

new AppBannerInfoBarDelegateAndroid(event_request_id(), this, title,

- new SkBitmap(*icon),

+ icon_url, new SkBitmap(*icon),

web_app_data()));

infobar = new AppBannerInfoBarAndroid(std::move(delegate),