Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

chrome/browser/banners/app_banner_data_fetcher.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 131 matching lines @@
 
   // Records that a banner was shown. The |event_name| corresponds to the RAPPOR
   // metric being recorded.
   void RecordDidShowBanner(const std::string& event_name);
 
  private:
   // Callbacks for data retrieval.
   void OnDidHasManifest(bool has_manifest);
   void OnDidGetManifest(const content::Manifest& manifest);
   void OnDidCheckHasServiceWorker(bool has_service_worker);
-  void OnAppIconFetched(const SkBitmap& bitmap);
+  void OnAppIconFetched(const GURL& app_icon_url, const SkBitmap& bitmap);
 
   // Called when it is determined that the webapp has fulfilled the initial
   // criteria of having a manifest and a service worker.
   void OnHasServiceWorker(content::WebContents* web_contents);
 
   // Returns whether the given web app has already been installed.
   // Implemented on desktop platforms only.
   virtual bool IsWebAppInstalled(content::BrowserContext* browser_context,
                                  const GURL& start_url);
 
   // Record that the banner could be shown at this point, if the triggering
   // heuristic allowed.
   void RecordCouldShowBanner();
 
-  // Creates a banner for the app using the given |icon|.
-  virtual void ShowBanner(const SkBitmap* icon,
+  // Creates a banner for the app using the given icon.
+  virtual void ShowBanner(const GURL& icon_url,

[dominickn, 2016/06/15 19:17:14]

This needs to also fix up AppBannerDataFetcherDesktop::ShowBanner

[pkotwicz, 2016/06/15 20:34:24]

Done.

+                          const SkBitmap* icon,
                           const base::string16& title,
                           const std::string& referrer) = 0;
 
   // Returns whether the banner should be shown.
   bool CheckIfShouldShowBanner();
 
   // Returns whether the fetcher is active and web contents have not been
   // closed.
   bool CheckFetcherIsStillAlive(content::WebContents* web_contents);
 
   // Returns whether the given Manifest is following the requirements to show
   // a web app banner.
   static bool IsManifestValidForWebApp(const content::Manifest& manifest,
                                        content::WebContents* web_contents,
                                        bool is_debug_mode);
 
   const base::WeakPtr<Delegate> weak_delegate_;
   const int ideal_icon_size_in_dp_;
   const int minimum_icon_size_in_dp_;
   base::ObserverList<Observer> observer_list_;
   bool is_active_;
   bool was_canceled_by_page_;
   bool page_requested_prompt_;
   const bool is_debug_mode_;
   ui::PageTransition transition_type_;
   int event_request_id_;
+  GURL app_icon_url_;
   std::unique_ptr<SkBitmap> app_icon_;
   std::string referrer_;
 
   GURL validated_url_;
   base::string16 app_title_;
   content::Manifest web_app_data_;
 
   friend struct content::BrowserThread::DeleteOnThread<
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<AppBannerDataFetcher>;
   friend class AppBannerDataFetcherUnitTest;
   friend class base::RefCounted<AppBannerDataFetcher>;
   DISALLOW_COPY_AND_ASSIGN(AppBannerDataFetcher);
 };
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_DATA_FETCHER_H_