mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl - Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/validation_errors.cc ('K') | « mojo/public/cpp/bindings/tests/validation_context_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('j') | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

index 4b81a787dbb60316a4345e1f2ad555af244e5687..36856e8f601e8bb50b3b52d7aff2169aabb64ecc 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/enum_macros.tmpl

@@ -30,11 +30,13 @@ struct {{enum.name}}_Data {

return false;

}

- static bool Validate(int32_t value) {

+ static bool Validate(int32_t value,

+ mojo::internal::ValidationContext* validation_context) {

if (kIsExtensible || IsKnownValue(value))

return true;

- ReportValidationError(mojo::internal::VALIDATION_ERROR_UNKNOWN_ENUM_VALUE);

+ ReportValidationError(validation_context,

+ mojo::internal::VALIDATION_ERROR_UNKNOWN_ENUM_VALUE);

return false;

}

};