Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: mojo/public/cpp/bindings/lib/interface_ptr_state.h

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/interface_ptr_state.h
diff --git a/mojo/public/cpp/bindings/lib/interface_ptr_state.h b/mojo/public/cpp/bindings/lib/interface_ptr_state.h
index 8cda57d2bdf34b790e1fa4ed6d4330a85b3a813f..3f905e79802a51d386427c57e59590239eb3aaad 100644
--- a/mojo/public/cpp/bindings/lib/interface_ptr_state.h
+++ b/mojo/public/cpp/bindings/lib/interface_ptr_state.h
@@ -164,11 +164,12 @@ class InterfacePtrState<Interface, false> {
return;
FilterChain filters;
- filters.Append<MessageHeaderValidator>();
+ filters.Append<MessageHeaderValidator>(Interface::Name_);
filters.Append<typename Interface::ResponseValidator_>();
router_ = new Router(std::move(handle_), std::move(filters), false,
std::move(runner_));
+ router_->set_interface_name(Interface::Name_);
proxy_ = new Proxy(router_);
}
@@ -325,10 +326,12 @@ class InterfacePtrState<Interface, true> {
return;
router_ = new MultiplexRouter(true, std::move(handle_), runner_);
+ router_->SetMasterInterfaceName(Interface::Name_);
endpoint_client_.reset(new InterfaceEndpointClient(
router_->CreateLocalEndpointHandle(kMasterInterfaceId), nullptr,
base::WrapUnique(new typename Interface::ResponseValidator_()), false,
std::move(runner_)));
+ endpoint_client_->set_interface_name(Interface::Name_);
proxy_.reset(new Proxy(endpoint_client_.get()));
proxy_->serialization_context()->router = endpoint_client_->router();
}

Powered by Google App Engine
This is Rietveld 408576698