Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: mojo/public/cpp/bindings/lib/control_message_handler.h

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/control_message_handler.h
diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.h b/mojo/public/cpp/bindings/lib/control_message_handler.h
index 13b5aa6214ea5e08b07cc057e8638ba0f02ad0a1..8a12f8505947580ccd10770c73e3ae3c55c6ce0a 100644
--- a/mojo/public/cpp/bindings/lib/control_message_handler.h
+++ b/mojo/public/cpp/bindings/lib/control_message_handler.h
@@ -19,19 +19,21 @@ class ControlMessageHandler : public MessageReceiverWithResponderStatus {
public:
static bool IsControlMessage(const Message* message);
- explicit ControlMessageHandler(uint32_t interface_version);
+ ControlMessageHandler(const char* interface_name,
+ uint32_t interface_version);
~ControlMessageHandler() override;
// Call the following methods only if IsControlMessage() returned true.
- bool Accept(Message* message) override;
+ Result Accept(Message* message) override;
// Takes ownership of |responder|.
- bool AcceptWithResponder(Message* message,
- MessageReceiverWithStatus* responder) override;
+ Result AcceptWithResponder(Message* message,
+ MessageReceiverWithStatus* responder) override;
private:
- bool Run(Message* message, MessageReceiverWithStatus* responder);
- bool RunOrClosePipe(Message* message);
+ Result Run(Message* message, MessageReceiverWithStatus* responder);
+ Result RunOrClosePipe(Message* message);
+ const char* interface_name_;
uint32_t interface_version_;
SerializationContext context_;

Powered by Google App Engine
This is Rietveld 408576698