Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
diff --git a/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
index 3621fe4d68f6b76a9fe896f9bd5a346361f561ea..7f4603691e5fc1d5d6b9056cb5e555a953271f04 100644
--- a/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
+++ b/mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl
@@ -8,13 +8,14 @@
}
// static
-bool {{class_name}}::Validate(const void* data,
- mojo::internal::BoundsChecker* bounds_checker,
- bool inlined) {
+bool {{class_name}}::Validate(
+ const void* data,
+ mojo::internal::ValidationContext* validation_context,
+ bool inlined) {
if (!data)
return true;
- if (!ValidateUnionHeaderAndClaimMemory(data, inlined, bounds_checker))
+ if (!ValidateUnionHeaderAndClaimMemory(data, inlined, validation_context))
return false;
const {{class_name}}* object = static_cast<const {{class_name}}*>(data);
@@ -30,6 +31,7 @@ bool {{class_name}}::Validate(const void* data,
{%- endfor %}
default: {
ReportValidationError(
+ validation_context,
mojo::internal::VALIDATION_ERROR_UNKNOWN_UNION_TAG,
"unknown tag in {{union.name}}");
return false;

Powered by Google App Engine
This is Rietveld 408576698