mojo/public/cpp/bindings/tests/router_test_util.h - Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/router_test_util.h

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/message.h ('K') | « mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc ('k') | mojo/public/cpp/bindings/tests/router_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/router_test_util.h

diff --git a/mojo/public/cpp/bindings/tests/router_test_util.h b/mojo/public/cpp/bindings/tests/router_test_util.h

index c6fb372d3f426283dd19e58496bd2cee0a105b2b..d8bd9e6f5d00d464056b7cde94bddedf1e36bf45 100644

--- a/mojo/public/cpp/bindings/tests/router_test_util.h

+++ b/mojo/public/cpp/bindings/tests/router_test_util.h

@@ -29,7 +29,7 @@ class MessageAccumulator : public MessageReceiver {

const base::Closure& closure = base::Closure());

~MessageAccumulator() override;

- bool Accept(Message* message) override;

+ bool Accept(Message* message, Error* error) override;

private:

MessageQueue* queue_;

@@ -40,10 +40,11 @@ class ResponseGenerator : public MessageReceiverWithResponderStatus {

public:

ResponseGenerator();

- bool Accept(Message* message) override;

+ bool Accept(Message* message, Error* error) override;

bool AcceptWithResponder(Message* message,

- MessageReceiverWithStatus* responder) override;

+ MessageReceiverWithStatus* responder,

+ Error* error) override;

bool SendResponse(uint32_t name,

uint64_t request_id,

@@ -59,7 +60,8 @@ class LazyResponseGenerator : public ResponseGenerator {

~LazyResponseGenerator() override;

bool AcceptWithResponder(Message* message,

- MessageReceiverWithStatus* responder) override;

+ MessageReceiverWithStatus* responder,

+ Error* error) override;

bool has_responder() const { return !!responder_; }