Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: mojo/public/cpp/bindings/lib/connector.h

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/connector.h
diff --git a/mojo/public/cpp/bindings/lib/connector.h b/mojo/public/cpp/bindings/lib/connector.h
index 243159ef32fdbe0417824bd0a50431a39903f96a..2e3c6d6b61334e6b63e3e2dfe7a46bb2f7daec02 100644
--- a/mojo/public/cpp/bindings/lib/connector.h
+++ b/mojo/public/cpp/bindings/lib/connector.h
@@ -12,6 +12,7 @@
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_checker.h"
#include "mojo/public/cpp/bindings/callback.h"
+#include "mojo/public/cpp/bindings/error.h"
#include "mojo/public/cpp/bindings/lib/sync_handle_watcher.h"
#include "mojo/public/cpp/bindings/message.h"
#include "mojo/public/cpp/system/core.h"
@@ -99,7 +100,7 @@ class Connector : public MessageReceiver {
// an error because it believes the other end is malicious). In order to
// appear to the user that the connector still binds to a message pipe, it
// creates a new message pipe, closes one end and binds to the other.
- void RaiseError();
+ void RaiseError(Error error);
// Is the connector bound to a MessagePipe handle?
bool is_valid() const {
@@ -117,7 +118,7 @@ class Connector : public MessageReceiver {
void ResumeIncomingMethodCallProcessing();
// MessageReceiver implementation:
- bool Accept(Message* message) override;
+ bool Accept(Message* message, Error* error) override;
MessagePipeHandle handle() const {
DCHECK(thread_checker_.CalledOnValidThread());

Powered by Google App Engine
This is Rietveld 408576698