Mojo: Report bindings validation errors via MojoNotifyBadMessage

mojo/public/cpp/bindings/lib/validation_errors.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "mojo/public/cpp/bindings/callback.h"
+#include "mojo/public/cpp/bindings/lib/validation_context.h"
 
 namespace mojo {
 namespace internal {
 
 enum ValidationError {
   // There is no validation error.
   VALIDATION_ERROR_NONE,
   // An object (struct or array) is not 8-byte aligned.
   VALIDATION_ERROR_MISALIGNED_OBJECT,
   // An object is not contained inside the message data, or it overlaps other
@@ skipping 34 matching lines @@
   // there isn't one.
   VALIDATION_ERROR_MESSAGE_HEADER_MISSING_REQUEST_ID,
   // The |name| field in a message header contains an unexpected value.
   VALIDATION_ERROR_MESSAGE_HEADER_UNKNOWN_METHOD,
   // Two parallel arrays which are supposed to represent a map have different
   // lengths.
   VALIDATION_ERROR_DIFFERENT_SIZED_ARRAYS_IN_MAP,
   // Attempted to deserialize a tagged union with an unknown tag.
   VALIDATION_ERROR_UNKNOWN_UNION_TAG,
   // A value of a non-extensible enum type is unknown.
-  VALIDATION_ERROR_UNKNOWN_ENUM_VALUE
+  VALIDATION_ERROR_UNKNOWN_ENUM_VALUE,
+  // Deserialization of some message parameter or struct field failed, for

[yzshen1, 2016/06/15 22:20:09]

nit: maybe simply say "Message deserialization failure, for example..."

"message parameter or struct field" don't cover everything (it could be a union
field, array element etc.)

[Ken Rockot(use gerrit already), 2016/06/15 22:38:23]

Done

+  // example due to rejection by custom validation logic.
+  VALIDATION_ERROR_DESERIALIZATION_FAILED,
 };
 
 const char* ValidationErrorToString(ValidationError error);
 
-void ReportValidationError(ValidationError error,
+void ReportValidationError(ValidationContext* context,
+                           ValidationError error,
                            const char* description = nullptr);
 
 // Only used by validation tests and when there is only one thread doing message
 // validation.
 class ValidationErrorObserverForTesting {
  public:
   explicit ValidationErrorObserverForTesting(const Callback<void()>& callback);
   ~ValidationErrorObserverForTesting();
 
   ValidationError last_error() const { return last_error_; }
@@ skipping 44 matching lines @@
 //
 // In non-debug build, does nothing (not even compiling |condition|).
 #define MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(condition, error,    \
                                                  description)         \
   DLOG_IF(FATAL, (condition) && !ReportSerializationWarning(error))   \
       << "The outgoing message will trigger "                         \
       << ValidationErrorToString(error) << " at the receiving side (" \
       << description << ").";
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_