Mojo: Report bindings validation errors via MojoNotifyBadMessage

mojo/public/cpp/bindings/lib/pipe_control_message_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/lib/pipe_control_message_handler.h"
 
 #include "base/logging.h"
 #include "mojo/public/cpp/bindings/lib/message_builder.h"
 #include "mojo/public/cpp/bindings/lib/pipe_control_message_handler_delegate.h"
 #include "mojo/public/cpp/bindings/lib/serialization.h"
 #include "mojo/public/cpp/bindings/lib/validation_util.h"
 #include "mojo/public/interfaces/bindings/pipe_control_messages.mojom.h"
 
 namespace mojo {
 namespace internal {
 
 PipeControlMessageHandler::PipeControlMessageHandler(
     PipeControlMessageHandlerDelegate* delegate)
     : delegate_(delegate) {}
 
 PipeControlMessageHandler::~PipeControlMessageHandler() {}
 
 // static
 bool PipeControlMessageHandler::IsPipeControlMessage(const Message* message) {
   return !IsValidInterfaceId(message->interface_id());
 }
 
-bool PipeControlMessageHandler::Accept(Message* message) {
-  if (!Validate(message))
-    return false;
+MessageReceiver::Result PipeControlMessageHandler::Accept(Message* message) {
+  Result result = Validate(message);
+  if (!result.Succeeded())
+    return result;
 
-  if (message->name() == pipe_control::kRunOrClosePipeMessageId)
-    return RunOrClosePipe(message);
+  if (message->name() == pipe_control::kRunOrClosePipeMessageId) {
+    if (RunOrClosePipe(message))
+      return Result::ForSuccess();
+    return Result::ForBadControlMessage(interface_name_, message);
+  }
 
   NOTREACHED();
-  return false;
+  return Result::ForUnknownError();
 }
 
-bool PipeControlMessageHandler::Validate(const Message* message) {
+MessageReceiver::Result PipeControlMessageHandler::Validate(Message* message) {
   if (message->name() == pipe_control::kRunOrClosePipeMessageId) {
     if (!ValidateMessageIsRequestWithoutResponse(message))
-      return false;
-    return ValidateMessagePayload<
-        pipe_control::internal::RunOrClosePipeMessageParams_Data>(message);
+      return Result::ForBadControlMessage(interface_name_, message);
+    if (!ValidateMessagePayload<
+        pipe_control::internal::RunOrClosePipeMessageParams_Data>(message))
+      return Result::ForBadControlMessage(interface_name_, message);
+    return Result::ForSuccess();
   }
 
-  return false;
+  return Result::ForBadControlMessage(interface_name_, message);
 }
 
 bool PipeControlMessageHandler::RunOrClosePipe(Message* message) {
   pipe_control::internal::RunOrClosePipeMessageParams_Data* params =
       reinterpret_cast<
           pipe_control::internal::RunOrClosePipeMessageParams_Data*>(
           message->mutable_payload());
   params->DecodePointers();
 
   pipe_control::RunOrClosePipeMessageParamsPtr params_ptr;
@@ skipping 10 matching lines @@
             ->id);
   }
 
   DVLOG(1) << "Unsupported command in a RunOrClosePipe message pipe control "
            << "message. Closing the pipe.";
   return false;
 }
 
 }  // namespace internal
 }  // namespace mojo