Mojo: Report bindings validation errors via MojoNotifyBadMessage

mojo/public/cpp/bindings/lib/control_message_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/lib/control_message_handler.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
 #include "base/logging.h"
+#include "base/macros.h"
 #include "mojo/public/cpp/bindings/lib/message_builder.h"
 #include "mojo/public/cpp/bindings/lib/serialization.h"
 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h"
 
 namespace mojo {
 namespace internal {
 
 // static
 bool ControlMessageHandler::IsControlMessage(const Message* message) {
   return message->header()->name == kRunMessageId ||
          message->header()->name == kRunOrClosePipeMessageId;
 }
 
-ControlMessageHandler::ControlMessageHandler(uint32_t interface_version)
-    : interface_version_(interface_version) {
+ControlMessageHandler::ControlMessageHandler(const char* interface_name,
+                                             uint32_t interface_version)
+    : interface_name_(interface_name), interface_version_(interface_version) {
 }
 
 ControlMessageHandler::~ControlMessageHandler() {
 }
 
-bool ControlMessageHandler::Accept(Message* message) {
+MessageReceiver::Result ControlMessageHandler::Accept(Message* message) {
   if (message->header()->name == kRunOrClosePipeMessageId)
     return RunOrClosePipe(message);
 
   NOTREACHED();
-  return false;
+  return Result::ForUnknownError();
 }
 
-bool ControlMessageHandler::AcceptWithResponder(
+MessageReceiver::Result ControlMessageHandler::AcceptWithResponder(
     Message* message,
     MessageReceiverWithStatus* responder) {
   if (message->header()->name == kRunMessageId)
     return Run(message, responder);
 
   NOTREACHED();
-  return false;
+  return Result::ForUnknownError();
 }
 
-bool ControlMessageHandler::Run(Message* message,
-                                MessageReceiverWithStatus* responder) {
+MessageReceiver::Result ControlMessageHandler::Run(
+    Message* message,
+    MessageReceiverWithStatus* responder) {
   RunResponseMessageParamsPtr response_params_ptr(
       RunResponseMessageParams::New());
   response_params_ptr->reserved0 = 16u;
   response_params_ptr->reserved1 = 0u;
   response_params_ptr->query_version_result = QueryVersionResult::New();
   response_params_ptr->query_version_result->version = interface_version_;
 
   size_t size = PrepareToSerialize<RunResponseMessageParamsPtr>(
       response_params_ptr, &context_);
   ResponseMessageBuilder builder(kRunMessageId, size, message->request_id());
 
   RunResponseMessageParams_Data* response_params = nullptr;
   Serialize<RunResponseMessageParamsPtr>(response_params_ptr, builder.buffer(),
                                          &response_params, &context_);
   response_params->EncodePointers();
-  bool ok = responder->Accept(builder.message());
-  ALLOW_UNUSED_LOCAL(ok);
+
+  ignore_result(responder->Accept(builder.message()));
   delete responder;
 
-  return true;
+  return Result::ForSuccess();
 }
 
-bool ControlMessageHandler::RunOrClosePipe(Message* message) {
+MessageReceiver::Result ControlMessageHandler::RunOrClosePipe(
+    Message* message) {
   RunOrClosePipeMessageParams_Data* params =
       reinterpret_cast<RunOrClosePipeMessageParams_Data*>(
           message->mutable_payload());
   params->DecodePointers();
 
   RunOrClosePipeMessageParamsPtr params_ptr;
   Deserialize<RunOrClosePipeMessageParamsPtr>(params, &params_ptr, &context_);
 
-  return interface_version_ >= params_ptr->require_version->version;
+  if (interface_version_ < params_ptr->require_version->version)
+    return Result::ForUnexpectedRequest(interface_name_, message);
+
+  return Result::ForSuccess();
 }
 
 }  // namespace internal
 }  // namespace mojo