Mojo: Report bindings validation errors via MojoNotifyBadMessage

mojo/public/cpp/bindings/tests/multiplex_router_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/lib/multiplex_router.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 57 matching lines @@
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
   ResponseGenerator generator;
   InterfaceEndpointClient client1(std::move(endpoint1_), &generator,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
 
   Message request;
   AllocRequestMessage(1, "hello", &request);
 
+  Error error;
   MessageQueue message_queue;
   base::RunLoop run_loop;
   client0.AcceptWithResponder(
       &request,
-      new MessageAccumulator(&message_queue, run_loop.QuitClosure()));
+      new MessageAccumulator(&message_queue, run_loop.QuitClosure()), &error);
 
   run_loop.Run();
 
   EXPECT_FALSE(message_queue.IsEmpty());
 
   Message response;
   message_queue.Pop(&response);
 
   EXPECT_EQ(std::string("hello world!"),
             std::string(reinterpret_cast<const char*>(response.payload())));
 
   // Send a second message on the pipe.
   Message request2;
   AllocRequestMessage(1, "hello again", &request2);
 
   base::RunLoop run_loop2;
   client0.AcceptWithResponder(
       &request2,
-      new MessageAccumulator(&message_queue, run_loop2.QuitClosure()));
+      new MessageAccumulator(&message_queue, run_loop2.QuitClosure()), &error);
 
   run_loop2.Run();
 
   EXPECT_FALSE(message_queue.IsEmpty());
 
   message_queue.Pop(&response);
 
   EXPECT_EQ(std::string("hello again world!"),
             std::string(reinterpret_cast<const char*>(response.payload())));
 }
 
 TEST_F(MultiplexRouterTest, BasicRequestResponse_Synchronous) {
   InterfaceEndpointClient client0(std::move(endpoint0_), nullptr,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
   ResponseGenerator generator;
   InterfaceEndpointClient client1(std::move(endpoint1_), &generator,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
 
   Message request;
   AllocRequestMessage(1, "hello", &request);
 
+  Error error;
   MessageQueue message_queue;
-  client0.AcceptWithResponder(&request, new MessageAccumulator(&message_queue));
+  client0.AcceptWithResponder(&request, new MessageAccumulator(&message_queue),
+                              &error);
 
   router1_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);
   router0_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);
 
   EXPECT_FALSE(message_queue.IsEmpty());
 
   Message response;
   message_queue.Pop(&response);
 
   EXPECT_EQ(std::string("hello world!"),
             std::string(reinterpret_cast<const char*>(response.payload())));
 
   // Send a second message on the pipe.
   Message request2;
   AllocRequestMessage(1, "hello again", &request2);
 
   client0.AcceptWithResponder(&request2,
-                              new MessageAccumulator(&message_queue));
+                              new MessageAccumulator(&message_queue), &error);
 
   router1_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);
   router0_->WaitForIncomingMessage(MOJO_DEADLINE_INDEFINITE);
 
   EXPECT_FALSE(message_queue.IsEmpty());
 
   message_queue.Pop(&response);
 
   EXPECT_EQ(std::string("hello again world!"),
             std::string(reinterpret_cast<const char*>(response.payload())));
 }
 
 TEST_F(MultiplexRouterTest, RequestWithNoReceiver) {
   InterfaceEndpointClient client0(std::move(endpoint0_), nullptr,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
   InterfaceEndpointClient client1(std::move(endpoint1_), nullptr,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
 
   // Without an incoming receiver set on client1, we expect client0 to observe
   // an error as a result of sending a message.
 
   Message request;
   AllocRequestMessage(1, "hello", &request);
 
+  Error error;
   MessageQueue message_queue;
   base::RunLoop run_loop, run_loop2;
   client0.set_connection_error_handler(run_loop.QuitClosure());
   client1.set_connection_error_handler(run_loop2.QuitClosure());
   client0.AcceptWithResponder(
-      &request, new MessageAccumulator(&message_queue, run_loop.QuitClosure()));
+      &request, new MessageAccumulator(&message_queue, run_loop.QuitClosure()),
+      &error);
 
   run_loop.Run();
   run_loop2.Run();
 
   EXPECT_TRUE(client0.encountered_error());
   EXPECT_TRUE(client1.encountered_error());
   EXPECT_TRUE(message_queue.IsEmpty());
 }
 
 // Tests MultiplexRouter using the LazyResponseGenerator. The responses will not
 // be sent until after the requests have been accepted.
 TEST_F(MultiplexRouterTest, LazyResponses) {
   InterfaceEndpointClient client0(std::move(endpoint0_), nullptr,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
   base::RunLoop run_loop;
   LazyResponseGenerator generator(run_loop.QuitClosure());
   InterfaceEndpointClient client1(std::move(endpoint1_), &generator,
                                   base::WrapUnique(new PassThroughFilter()),
                                   false, base::ThreadTaskRunnerHandle::Get());
 
   Message request;
   AllocRequestMessage(1, "hello", &request);
 
+  Error error;
   MessageQueue message_queue;
   base::RunLoop run_loop2;
   client0.AcceptWithResponder(
       &request,
-      new MessageAccumulator(&message_queue, run_loop2.QuitClosure()));
+      new MessageAccumulator(&message_queue, run_loop2.QuitClosure()), &error);
   run_loop.Run();
 
   // The request has been received but the response has not been sent yet.
   EXPECT_TRUE(message_queue.IsEmpty());
 
   // Send the response.
   EXPECT_TRUE(generator.responder_is_valid());
   generator.CompleteWithResponse();
   run_loop2.Run();
 
   // Check the response.
   EXPECT_FALSE(message_queue.IsEmpty());
   Message response;
   message_queue.Pop(&response);
   EXPECT_EQ(std::string("hello world!"),
             std::string(reinterpret_cast<const char*>(response.payload())));
 
   // Send a second message on the pipe.
   base::RunLoop run_loop3;
   generator.set_closure(run_loop3.QuitClosure());
   Message request2;
   AllocRequestMessage(1, "hello again", &request2);
 
   base::RunLoop run_loop4;
   client0.AcceptWithResponder(
       &request2,
-      new MessageAccumulator(&message_queue, run_loop4.QuitClosure()));
+      new MessageAccumulator(&message_queue, run_loop4.QuitClosure()), &error);
   run_loop3.Run();
 
   // The request has been received but the response has not been sent yet.
   EXPECT_TRUE(message_queue.IsEmpty());
 
   // Send the second response.
   EXPECT_TRUE(generator.responder_is_valid());
   generator.CompleteWithResponse();
   run_loop4.Run();
 
@@ skipping 27 matching lines @@
   bool error_handler_called1 = false;
   client1.set_connection_error_handler(
       [&error_handler_called1, &run_loop1]() {
         error_handler_called1 = true;
         run_loop1.Quit();
       });
 
   Message request;
   AllocRequestMessage(1, "hello", &request);
 
+  Error error;
   MessageQueue message_queue;
-  client0.AcceptWithResponder(&request, new MessageAccumulator(&message_queue));
+  client0.AcceptWithResponder(&request, new MessageAccumulator(&message_queue),
+                              &error);
   run_loop3.Run();
 
   // The request has been received but no response has been sent.
   EXPECT_TRUE(message_queue.IsEmpty());
 
   // Destroy the responder MessagerReceiver but don't send any response.
   generator.CompleteWithoutResponse();
   run_loop0.Run();
   run_loop1.Run();
 
@@ skipping 24 matching lines @@
     InterfaceEndpointClient client0(std::move(endpoint0_), nullptr,
                                     base::WrapUnique(new PassThroughFilter()),
                                     false, base::ThreadTaskRunnerHandle::Get());
     InterfaceEndpointClient client1(std::move(endpoint1_), &generator,
                                     base::WrapUnique(new PassThroughFilter()),
                                     false, base::ThreadTaskRunnerHandle::Get());
 
     Message request;
     AllocRequestMessage(1, "hello", &request);
 
+    Error error;
     MessageQueue message_queue;
     client0.AcceptWithResponder(&request,
-                                new MessageAccumulator(&message_queue));
+                                new MessageAccumulator(&message_queue), &error);
 
     run_loop.Run();
 
     EXPECT_TRUE(generator.has_responder());
   }
 
   EXPECT_FALSE(generator.responder_is_valid());
   generator.CompleteWithResponse();  // This should end up doing nothing.
 }
 
 // TODO(yzshen): add more tests.
 
 }  // namespace
 }  // namespace test
 }  // namespace mojo