Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: mojo/public/cpp/bindings/lib/pipe_control_message_proxy.cc

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/pipe_control_message_proxy.h" 5 #include "mojo/public/cpp/bindings/lib/pipe_control_message_proxy.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 17 matching lines...) Expand all
28 size_t size = 28 size_t size =
29 PrepareToSerialize<pipe_control::RunOrClosePipeMessageParamsPtr>( 29 PrepareToSerialize<pipe_control::RunOrClosePipeMessageParamsPtr>(
30 params_ptr, context); 30 params_ptr, context);
31 MessageBuilder builder(pipe_control::kRunOrClosePipeMessageId, size); 31 MessageBuilder builder(pipe_control::kRunOrClosePipeMessageId, size);
32 32
33 pipe_control::internal::RunOrClosePipeMessageParams_Data* params = nullptr; 33 pipe_control::internal::RunOrClosePipeMessageParams_Data* params = nullptr;
34 Serialize<pipe_control::RunOrClosePipeMessageParamsPtr>( 34 Serialize<pipe_control::RunOrClosePipeMessageParamsPtr>(
35 params_ptr, builder.buffer(), &params, context); 35 params_ptr, builder.buffer(), &params, context);
36 params->EncodePointers(); 36 params->EncodePointers();
37 builder.message()->set_interface_id(kInvalidInterfaceId); 37 builder.message()->set_interface_id(kInvalidInterfaceId);
38 bool ok = receiver->Accept(builder.message()); 38 Error send_error;
39 bool ok = receiver->Accept(builder.message(), &send_error);
39 // This return value may be ignored as !ok implies the underlying message pipe 40 // This return value may be ignored as !ok implies the underlying message pipe
40 // has encountered an error, which will be visible through other means. 41 // has encountered an error, which will be visible through other means.
41 ALLOW_UNUSED_LOCAL(ok); 42 ALLOW_UNUSED_LOCAL(ok);
42 } 43 }
43 44
44 } // namespace 45 } // namespace
45 46
46 PipeControlMessageProxy::PipeControlMessageProxy(MessageReceiver* receiver) 47 PipeControlMessageProxy::PipeControlMessageProxy(MessageReceiver* receiver)
47 : receiver_(receiver) {} 48 : receiver_(receiver) {}
48 49
(...skipping 18 matching lines...) Expand all
67 68
68 pipe_control::RunOrClosePipeInputPtr input( 69 pipe_control::RunOrClosePipeInputPtr input(
69 pipe_control::RunOrClosePipeInput::New()); 70 pipe_control::RunOrClosePipeInput::New());
70 input->set_associated_endpoint_closed_before_sent_event(std::move(event)); 71 input->set_associated_endpoint_closed_before_sent_event(std::move(event));
71 72
72 SendRunOrClosePipeMessage(receiver_, std::move(input), &context_); 73 SendRunOrClosePipeMessage(receiver_, std::move(input), &context_);
73 } 74 }
74 75
75 } // namespace internal 76 } // namespace internal
76 } // namespace mojo 77 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698