[Android] Dedup content_browsertests test setup from gtests.

[Android] Dedup content_browsertests test setup from gtests.
    
- This also changes the command for running content_browsertests
  to be in line with other gtest targets
- Additional cleanup: get rid of --exe option and fall back
  to using exe if apk is not found
  
TEST=test_runner.py gtest -s content_browsertests
BUG=261950
R=bulach@chromium.org, craigdh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214421

[frankf, 2013-07-29 17:44:21]

+ilevy for buildbot/

[craigdh, 2013-07-29 20:02:08]

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:283: suite_name, build_type)
fits on the previous line

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_package_exe.py (right):

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
build/android/pylib/gtest/test_package_exe.py:126: target_name = self.suite_path
+ '_' + adb._device + '_stripped'
Shouldn't be using a private member of adb. Add a getter to adb?

[frankf, 2013-07-29 21:13:30]

ptal

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:283: suite_name, build_type)
On 2013/07/29 20:02:08, craigdh wrote:
> fits on the previous line

Done.

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
File build/android/pylib/gtest/test_package_exe.py (right):

https://codereview.chromium.org/20649002/diff/20001/build/android/pylib/gtest...
build/android/pylib/gtest/test_package_exe.py:126: target_name = self.suite_path
+ '_' + adb._device + '_stripped'
On 2013/07/29 20:02:08, craigdh wrote:
> Shouldn't be using a private member of adb. Add a getter to adb?

Done.

[craigdh, 2013-07-29 22:10:17]

lgtm.

[bulach, 2013-07-30 10:21:18]

lgtm, thanks!

just in case, there's a hidden evil stepchild in the perf basement:
http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4/builds/50...
it ends up calling:
build/android/run_tests.py --release -s cc_perftests

I don't think it'll be affected, but wouldn't hurt to double check it's fine.

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:193: return runner_factory(device,
1).GetAllTests()
nit: why 1 instead of 0?

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:307: TestRunnerFactory, attached_devices)
nit: align

[frankf, 2013-07-30 17:56:16]

cc_perftests call should still work. I'll throw a CL your way to update it to
call test_runner.

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
File build/android/pylib/gtest/setup.py (right):

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:193: return runner_factory(device,
1).GetAllTests()
Hmm. random bit corruption :)

On 2013/07/30 10:21:18, bulach wrote:
> nit: why 1 instead of 0?

https://codereview.chromium.org/20649002/diff/30001/build/android/pylib/gtest...
build/android/pylib/gtest/setup.py:307: TestRunnerFactory, attached_devices)
On 2013/07/30 10:21:18, bulach wrote:
> nit: align

Done.

[frankf, 2013-07-30 20:16:26]

Committed patchset #3 manually as r214421 (presubmit successful).