printing/image.cc - Issue 2064843002: PdfMetafileSkia: start supporting more document types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/image.cc

Issue 2064843002: PdfMetafileSkia: start supporting more document types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-06-14 (Tuesday) 10:42:59 EDT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: printing/image.cc

diff --git a/printing/image.cc b/printing/image.cc

index a0376bb048c6e79061cd34ec67755d82e6eaa894..68faf9775ebad8349803e33ff1eda7ef8a259c95 100644

--- a/printing/image.cc

+++ b/printing/image.cc

@@ -152,7 +152,7 @@ bool Image::LoadPng(const std::string& compressed) {

bool Image::LoadMetafile(const std::string& data) {

Lei Zhang 2016/06/14 18:02:19 Looks like this is gone now with r399738 landed.

DCHECK(!data.empty());

- PdfMetafileSkia metafile;

+ PdfMetafileSkia metafile(PDF_SKIA_DOCUMENT_TYPE);

if (!metafile.InitFromData(data.data(),

base::checked_cast<uint32_t>(data.size())))

return false;

« no previous file with comments | « components/printing/renderer/print_web_view_helper_linux.cc ('k') | printing/pdf_metafile_skia.h » ('j') | no next file with comments »