Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206483010: [webcrypto] Refactor some layout tests. (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Refactor some layout tests. * Splits up large tests into smaller files. * Extracts common key data to its own file * Reduces use of shouldRejectPromiseWithNull() BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -1287 lines) Patch
A LayoutTests/crypto/aes-cbc-decrypt-failure.html View 1 chunk +72 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/aes-cbc-decrypt-failure-expected.txt View 1 chunk +9 lines, -7 lines 0 comments Download
A + LayoutTests/crypto/aes-cbc-encrypt-decrypt.html View 4 chunks +12 lines, -256 lines 0 comments Download
A LayoutTests/crypto/aes-cbc-encrypt-decrypt-expected.txt View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html View 1 chunk +57 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/aes-cbc-parseAlgorithm-failures-expected.txt View 1 chunk +9 lines, -2 lines 0 comments Download
A LayoutTests/crypto/aes-ctr-parseAlgorithm-failures.html View 1 chunk +64 lines, -0 lines 0 comments Download
A LayoutTests/crypto/aes-ctr-parseAlgorithm-failures-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/aes-gcm-encrypt-decrypt.html View 4 chunks +11 lines, -242 lines 0 comments Download
A LayoutTests/crypto/aes-gcm-encrypt-decrypt-expected.txt View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/crypto/aes-gcm-parseAlgorithm-failures.html View 1 chunk +68 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/aes-gcm-parseAlgorithm-failures-expected.txt View 1 chunk +16 lines, -12 lines 0 comments Download
A + LayoutTests/crypto/aes-key-algorithm-mismatch.html View 1 chunk +18 lines, -23 lines 0 comments Download
A + LayoutTests/crypto/aes-key-algorithm-mismatch-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
A LayoutTests/crypto/aes-key-usages.html View 1 chunk +63 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/aes-key-usages-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M LayoutTests/crypto/clone-rsaHashedKey-public.html View 5 chunks +7 lines, -30 lines 0 comments Download
M LayoutTests/crypto/clone-rsaKey-public.html View 5 chunks +7 lines, -30 lines 0 comments Download
D LayoutTests/crypto/digest.html View 1 chunk +0 lines, -115 lines 0 comments Download
D LayoutTests/crypto/digest-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
A LayoutTests/crypto/digest-failures.html View 1 chunk +43 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/digest-failures-expected.txt View 2 chunks +3 lines, -15 lines 0 comments Download
D LayoutTests/crypto/encrypt-decrypt.html View 1 chunk +0 lines, -358 lines 0 comments Download
D LayoutTests/crypto/encrypt-decrypt-expected.txt View 1 chunk +0 lines, -121 lines 0 comments Download
M LayoutTests/crypto/exportKey.html View 2 chunks +2 lines, -1 line 0 comments Download
A LayoutTests/crypto/import-aes-key-bad-length.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/crypto/import-aes-key-bad-length-expected.txt View 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/crypto/importKey.html View 4 chunks +7 lines, -6 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 4 chunks +9 lines, -9 lines 0 comments Download
A LayoutTests/crypto/resources/keys.js View 1 chunk +65 lines, -0 lines 0 comments Download
A + LayoutTests/crypto/sha-digest.html View 3 chunks +7 lines, -17 lines 0 comments Download
A + LayoutTests/crypto/sha-digest-expected.txt View 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/crypto/sign-verify.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/crypto/wrap-unwrap.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
6 years, 9 months ago (2014-03-21 02:35:31 UTC) #1
abarth-chromium
rslgtm
6 years, 9 months ago (2014-03-21 12:56:03 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 12:56:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/206483010/1
6 years, 9 months ago (2014-03-21 12:56:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 12:59:56 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-21 12:59:57 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-24 23:08:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/206483010/1
6 years, 9 months ago (2014-03-24 23:08:05 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 00:13:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 169894

Powered by Google App Engine
This is Rietveld 408576698