Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2064813002: Fixing the order of methods in ChromeLauncherControllerImpl. (Closed)

Created:
4 years, 6 months ago by mfomitchev
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@launcher_controller_mus_6
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing the order of methods in ChromeLauncherControllerImpl. Fixing the order of methods in .cc to match that in .h. No code changes. BUG=NONE Committed: https://crrev.com/78ff2ac7064126a8211a46ca88c4ad087b573fd1 Cr-Commit-Position: refs/heads/master@{#399534}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -334 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 16 chunks +361 lines, -334 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
mfomitchev
4 years, 6 months ago (2016-06-13 18:49:47 UTC) #3
msw
lgtm with a nit. https://codereview.chromium.org/2064813002/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right): https://codereview.chromium.org/2064813002/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc#newcode1099 chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:1099: bool ChromeLauncherControllerImpl::GetAppIDForShelfIDConst( This is unused ...
4 years, 6 months ago (2016-06-13 19:15:26 UTC) #4
mfomitchev
https://codereview.chromium.org/2064813002/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc (right): https://codereview.chromium.org/2064813002/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc#newcode1099 chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc:1099: bool ChromeLauncherControllerImpl::GetAppIDForShelfIDConst( On 2016/06/13 19:15:25, msw wrote: > This ...
4 years, 6 months ago (2016-06-13 20:32:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064813002/1
4 years, 6 months ago (2016-06-13 20:51:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 21:06:30 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:06:32 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:09:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78ff2ac7064126a8211a46ca88c4ad087b573fd1
Cr-Commit-Position: refs/heads/master@{#399534}

Powered by Google App Engine
This is Rietveld 408576698