Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2064793004: Reland: Split the code for fetching images and for decoding images into two separate classes. This w (Closed)

Created:
4 years, 6 months ago by markusheintz_
Modified:
4 years, 6 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, droger+watchlist_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, sdefresne+watchlist_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, blundell+watchlist_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: https://codereview.chromium.org/2045233002/ Split the code for fetching images and for decoding images into two separate classes. This will all… Marc approved the small diff. So I'll TBR the original reviewers. BUG=609127 TBR=bauerb, mmenke, blundell Committed: https://crrev.com/c757076b114a75413f24ff0d78ec8409a4004d0e Cr-Commit-Position: refs/heads/master@{#399872}

Patch Set 1 #

Patch Set 2 : Only start image requests once (Fixes a bug). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -44 lines) Patch
A chrome/browser/search/suggestions/image_decoder_impl.h View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_decoder_impl.cc View 1 chunk +88 lines, -0 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.h View 4 chunks +21 lines, -17 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.cc View 1 3 chunks +29 lines, -26 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M components/image_fetcher.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M components/image_fetcher/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/image_fetcher/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A components/image_fetcher/image_data_fetcher.h View 1 chunk +56 lines, -0 lines 0 comments Download
A components/image_fetcher/image_data_fetcher.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A components/image_fetcher/image_decoder.h View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
markusheintz_
Marc can you please take a at patchset 1? This should fix the issue that ...
4 years, 6 months ago (2016-06-15 09:02:48 UTC) #3
markusheintz_
On 2016/06/15 09:02:48, markusheintz_ wrote: > Marc can you please take a at patchset 1? ...
4 years, 6 months ago (2016-06-15 09:06:54 UTC) #4
Marc Treib
On 2016/06/15 09:06:54, markusheintz_ wrote: > On 2016/06/15 09:02:48, markusheintz_ wrote: > > Marc can ...
4 years, 6 months ago (2016-06-15 09:52:15 UTC) #5
Marc Treib
On 2016/06/15 09:52:15, Marc Treib wrote: > On 2016/06/15 09:06:54, markusheintz_ wrote: > > On ...
4 years, 6 months ago (2016-06-15 09:53:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064793004/20001
4 years, 6 months ago (2016-06-15 10:01:57 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 10:17:38 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 10:17:43 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 10:19:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c757076b114a75413f24ff0d78ec8409a4004d0e
Cr-Commit-Position: refs/heads/master@{#399872}

Powered by Google App Engine
This is Rietveld 408576698