Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2064763003: Add function that converts string connection type to ECT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | net/nqe/network_quality_estimator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index d11b4841628cec93f6b83ffb75f15e6cd50f8035..9bacb5149aeae38d8d23f0828af86edca0d33d19 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -256,6 +256,14 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
SocketPerformanceWatcherFactory* GetSocketPerformanceWatcherFactory();
+ // Returns a string equivalent to |type|.
+ static const char* GetNameForEffectiveConnectionType(
+ EffectiveConnectionType type);
+
+ // Returns a EffectiveConnectionType equivalent to |connection_type_name|.
bengr 2016/06/20 14:44:16 a -> an
tbansal1 2016/06/20 20:16:35 Done.
+ static EffectiveConnectionType GetEffectiveConnectionTypeForName(
+ const std::string& connection_type_name);
+
protected:
// NetworkID is used to uniquely identify a network.
// For the purpose of network quality estimation and caching, a network is
@@ -306,10 +314,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
int32_t downstream_throughput_kbps,
int32_t upstream_throughput_kbps) override;
- // Return a string equivalent to |type|.
- const char* GetNameForEffectiveConnectionType(
- EffectiveConnectionType type) const;
-
// Returns the list of intervals at which the accuracy of network quality
// prediction should be recorded. Virtualized for testing.
virtual const std::vector<base::TimeDelta>& GetAccuracyRecordingIntervals()
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | net/nqe/network_quality_estimator_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698