Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2064753008: Revert of [Telemetry] Remove BuildbotOutputFormatter (Closed)

Created:
4 years, 6 months ago by nednguyen
Modified:
4 years, 6 months ago
CC:
catapult-reviews_chromium.org, Camillo Bruni, kouhei (in TOK), perezju, petrcermak, Primiano Tucci (use gerrit), rnephew (Reviews Here), telemetry-reviews_chromium.org, ulan, vmiura
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Remove BuildbotOutputFormatter (patchset #1 id:1 of https://codereview.chromium.org/2012793002/ ) Reason for revert: Other team is still using it. Original issue's description: > [Telemetry] Remove BuildbotOutputFormatter > > BUG=chromium:477056 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0fdcac0b5843b7002bee2f87b9af2f8d96ddba06 TBR=nednguyen@chromium.org,prasadv@chromium.org,robertocn@chromium.org,eakuefner@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:477056 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d1858050f3e805c900f1628f34d90c13d67b4cf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -2 lines) Patch
A telemetry/telemetry/internal/results/buildbot_output_formatter.py View 1 chunk +120 lines, -0 lines 0 comments Download
A telemetry/telemetry/internal/results/buildbot_output_formatter_unittest.py View 1 chunk +42 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/results/results_options.py View 5 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
Created Revert of [Telemetry] Remove BuildbotOutputFormatter
4 years, 6 months ago (2016-06-15 21:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064753008/1
4 years, 6 months ago (2016-06-15 21:42:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d1858050f3e805c900f1628f34d90c13d67b4cf6
4 years, 6 months ago (2016-06-15 22:07:21 UTC) #5
achuithb
lgtm
4 years, 6 months ago (2016-06-15 22:08:30 UTC) #7
nednguyen
4 years, 4 months ago (2016-07-26 18:08:46 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2180343002/ by nednguyen@google.com.

The reason for reverting is: crbug.com/620464 is fixed. There should be no one
still actively use BuildbotOutputFormatter.

Powered by Google App Engine
This is Rietveld 408576698