core/fxge/skia/DEPS - Issue 2064753002: add local caching for skia draws

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fxge/skia/DEPS

Issue 2064753002: add local caching for skia draws (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 '+third_party/skia/include'	2 '+fpdfsdk/include',
	Lei Zhang 2016/06/29 18:53:50 This is a layering violation. core/ should not dep This is a layering violation. core/ should not depend on fpdfsdk/ and public/. caryclark 2016/06/29 19:25:40 Sounds good. If unit tests belong in core director Show quoted text On 2016/06/29 18:53:50, Lei Zhang wrote: > This is a layering violation. core/ should not depend on fpdfsdk/ and public/. Sounds good. If unit tests belong in core directories, how should they depend on the includes they need to compile?
	3 '+public',

	4 '+third_party/skia/include',

3 ]	5 ]

OLD	NEW