Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 206473009: Move GraphicsContextTest to platform/ and fix the test environment. (Closed)

Created:
6 years, 9 months ago by jbroman
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move GraphicsContextTest to platform/ and fix the test environment. Previously, no Blink platform was initialized, leading to a segfault when a trace event occurred in NativeImageSkia::draw. This was fixed by making the platform unit test runner provide a minimal platform by default. The gyp target was adjusted to match the way blink_heap_unittests, for example, sets up its environment. This seems like a reasonable compromise between having a null platform and having a more complete platform implemented on the Chromium side, like the web unit tests have. BUG=353585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169982

Patch Set 1 #

Patch Set 2 : remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1134 lines) Patch
M Source/platform/TestingPlatformSupport.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/TestingPlatformSupport.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/blink_platform_tests.gyp View 1 chunk +56 lines, -39 lines 0 comments Download
A + Source/platform/graphics/GraphicsContextTest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/testing/RunAllTests.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
D Source/web/tests/GraphicsContextTest.cpp View 1 chunk +0 lines, -1095 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
I noticed that the only reason GraphicsContextTest doesn't run properly in blink_platform_unittests right now is ...
6 years, 9 months ago (2014-03-23 15:03:19 UTC) #1
dshwang
This CL allows platform/ get the similar test harness to wtf/. non-owner lgtm.
6 years, 9 months ago (2014-03-24 11:27:28 UTC) #2
jamesr
lgtm - thanks!
6 years, 9 months ago (2014-03-25 21:17:07 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 9 months ago (2014-03-25 21:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/206473009/20001
6 years, 9 months ago (2014-03-25 21:18:47 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 23:51:57 UTC) #6
Message was sent while issue was closed.
Change committed as 169982

Powered by Google App Engine
This is Rietveld 408576698