Fix assertions wrt concurrent OSR.

Fix assertions wrt concurrent OSR.

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20130

[Yang, 2014-03-20 13:33:05]

https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
File src/a64/full-codegen-a64.cc (left):

https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#...
src/a64/full-codegen-a64.cc:4883: 6 * kInstructionSize);
Those assertions are bogus. We want to be able to go from any state to any other
state. For example from ON_STACK_REPLACEMENT to OSR_AFTER_STACK_CHECK.

[ulan, 2014-03-20 13:50:45]

https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
File src/a64/full-codegen-a64.cc (left):

https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#...
src/a64/full-codegen-a64.cc:4883: 6 * kInstructionSize);
On 2014/03/20 13:33:05, Yang wrote:
> Those assertions are bogus. We want to be able to go from any state to any
other
> state. For example from ON_STACK_REPLACEMENT to OSR_AFTER_STACK_CHECK.

Let's fix the asserts instead of removing them. =)
Could you move the three asserts above switch and combine them?

[Yang, 2014-03-20 15:13:37]

On 2014/03/20 13:50:45, ulan wrote:
> https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc
> File src/a64/full-codegen-a64.cc (left):
> 
>
https://codereview.chromium.org/206473002/diff/1/src/a64/full-codegen-a64.cc#...
> src/a64/full-codegen-a64.cc:4883: 6 * kInstructionSize);
> On 2014/03/20 13:33:05, Yang wrote:
> > Those assertions are bogus. We want to be able to go from any state to any
> other
> > state. For example from ON_STACK_REPLACEMENT to OSR_AFTER_STACK_CHECK.
> 
> Let's fix the asserts instead of removing them. =)
> Could you move the three asserts above switch and combine them?

uploaded new patch set.

[ulan, 2014-03-20 15:20:36]

lgtm, thanks for fixing!

[Yang, 2014-03-20 15:23:38]

Committed patchset #2 manually as r20130 (presubmit successful).