Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2064713002: [ic] Temporary resurrect ICStateField to recover performance regression. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Temporary resurrect ICStateField to recover performance regression. Zero value of ICStateField part made megamorphic stub cache unusable. We need to revisit hashing algorithm in order to remove the ICStateField. BUG=chromium:619016 LOG=N Committed: https://crrev.com/6c5152406f29676b50eb9db10b82b7dfb92ac5d6 Cr-Commit-Position: refs/heads/master@{#36959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/objects.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064713002/1
4 years, 6 months ago (2016-06-13 14:38:20 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-13 14:38:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 15:07:04 UTC) #6
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-14 10:48:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064713002/1
4 years, 6 months ago (2016-06-14 10:49:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 10:53:17 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 10:54:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c5152406f29676b50eb9db10b82b7dfb92ac5d6
Cr-Commit-Position: refs/heads/master@{#36959}

Powered by Google App Engine
This is Rietveld 408576698