Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ic/ia32/access-compiler-ia32.cc

Issue 2064673002: [cleanup] Drop unused scratch register from {load,store}_calling_convention (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/mips/access-compiler-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ic/access-compiler.h" 7 #include "src/ic/access-compiler.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
11 11
12 #define __ ACCESS_MASM(masm) 12 #define __ ACCESS_MASM(masm)
13 13
14 void PropertyAccessCompiler::GenerateTailCall(MacroAssembler* masm, 14 void PropertyAccessCompiler::GenerateTailCall(MacroAssembler* masm,
15 Handle<Code> code) { 15 Handle<Code> code) {
16 __ jmp(code, RelocInfo::CODE_TARGET); 16 __ jmp(code, RelocInfo::CODE_TARGET);
17 } 17 }
18 18
19 19
20 Register* PropertyAccessCompiler::load_calling_convention() { 20 Register* PropertyAccessCompiler::load_calling_convention() {
21 // receiver, name, scratch1, scratch2, scratch3, scratch4. 21 // receiver, name, scratch1, scratch2, scratch3.
22 Register receiver = LoadDescriptor::ReceiverRegister(); 22 Register receiver = LoadDescriptor::ReceiverRegister();
23 Register name = LoadDescriptor::NameRegister(); 23 Register name = LoadDescriptor::NameRegister();
24 static Register registers[] = {receiver, name, ebx, eax, edi, no_reg}; 24 static Register registers[] = {receiver, name, ebx, eax, edi};
25 return registers; 25 return registers;
26 } 26 }
27 27
28 28
29 Register* PropertyAccessCompiler::store_calling_convention() { 29 Register* PropertyAccessCompiler::store_calling_convention() {
30 // receiver, name, scratch1, scratch2, scratch3. 30 // receiver, name, scratch1, scratch2.
31 Register receiver = StoreDescriptor::ReceiverRegister(); 31 Register receiver = StoreDescriptor::ReceiverRegister();
32 Register name = StoreDescriptor::NameRegister(); 32 Register name = StoreDescriptor::NameRegister();
33 static Register registers[] = {receiver, name, ebx, edi, no_reg}; 33 static Register registers[] = {receiver, name, ebx, edi};
34 return registers; 34 return registers;
35 } 35 }
36 36
37 #undef __ 37 #undef __
38 } // namespace internal 38 } // namespace internal
39 } // namespace v8 39 } // namespace v8
40 40
41 #endif // V8_TARGET_ARCH_IA32 41 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/mips/access-compiler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698