Make VM accept function values in assert statements.

Make VM accept function values in assert statements.

Fix for issue #18454.

BUG= http://dartbug.com/18454

Committed: https://github.com/dart-lang/sdk/commit/c56411d576caa5b2aa1d9527e43b1ccf25a72d85

[Lasse Reichstein Nielsen, 2016-06-14 13:48:02]

lrn@google.com changed reviewers:
+ hausner@google.com

[Lasse Reichstein Nielsen, 2016-06-14 13:48:03]

WDYT?

[hausner, 2016-06-14 17:51:31]

I suggest combining the two dart calls  for evaluating the condition and for
throwing the exception into one.

I can do that for you as a follow-on if you like.

https://codereview.chromium.org/2064663002/diff/1/runtime/lib/errors_patch.dart
File runtime/lib/errors_patch.dart (right):

https://codereview.chromium.org/2064663002/diff/1/runtime/lib/errors_patch.da...
runtime/lib/errors_patch.dart:29: static _handleCondition(condition) {
I'd call this function _evaluateCondition(), or something else appropriate if we
combine evaluation and the throw into one.

https://codereview.chromium.org/2064663002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2064663002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9204: return new(Z) IfNode(
Since you now call a Dart function to evaluate the assert condition, you might
as well move the if statement and throwing the exception in that same dart
function. That makes the generated code smaller. The only drawback is that you
have to pass two additional parameters.

[Lasse Reichstein Nielsen, 2016-06-15 05:57:02]

https://codereview.chromium.org/2064663002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2064663002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:9204: return new(Z) IfNode(
I'm not particularly worried about passing two extra integer literals, but I
would prefer to let you do it, to ensure that the correct positions are
attributed to the nodes. So, yes, please :)

[Lasse Reichstein Nielsen, 2016-06-15 08:08:42]

Description was changed from

==========
Make VM accept function values in assert statements.

Fix for issue #18454.

BUG= http://dartbug.com/18454
==========

to

==========
Make VM accept function values in assert statements.

Fix for issue #18454.

BUG= http://dartbug.com/18454

Committed:
https://github.com/dart-lang/sdk/commit/c56411d576caa5b2aa1d9527e43b1ccf25a72d85
==========

[Lasse Reichstein Nielsen, 2016-06-15 08:08:44]

Committed patchset #1 (id:1) manually as
c56411d576caa5b2aa1d9527e43b1ccf25a72d85 (presubmit successful).

[hausner, 2016-06-16 03:05:57]

LGTM.

I combined the two library calls into one in CL
https://codereview.chromium.org/2073623002/