Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2064633002: Promptly release cross-thread websocket bridge/proxy references (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
haraken, nhiroki
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Promptly release cross-thread websocket bridge/proxy references To prevent other threads using cross-thread persistents from accessing to-be-finalized websocket Peer and Bridge abstractions, promptly free them on becoming garbage. Delaying this until lazy sweeping runs risks (benignly) touching poisoned objects. R= BUG=619373 Committed: https://crrev.com/5c41255da77e26cfd08bc1ff29f09214dba3bea4 Cr-Commit-Position: refs/heads/master@{#399442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. verified locally (and by doing so.. no good reason not to ...
4 years, 6 months ago (2016-06-13 11:21:03 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-13 11:58:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064633002/1
4 years, 6 months ago (2016-06-13 12:09:00 UTC) #5
nhiroki
LGTM. Thank you for fixing this!
4 years, 6 months ago (2016-06-13 12:25:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 13:34:51 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 13:36:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c41255da77e26cfd08bc1ff29f09214dba3bea4
Cr-Commit-Position: refs/heads/master@{#399442}

Powered by Google App Engine
This is Rietveld 408576698