Source/core/rendering/compositing/CompositingReasonFinder.cpp - Issue 206463009: Rip out Settings::fixedPositionCreatesStackingContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 206463009: Rip out Settings::fixedPositionCreatesStackingContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: typo Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp

diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp

index e2f80be02c3fa794eb4dd51cbb785e8d2d38cf0f..fc725041fe9556b5dec77d1a6da72d72ebd3dbd9 100644

--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp

+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp

@@ -194,6 +194,7 @@ bool CompositingReasonFinder::requiresCompositingForPosition(RenderObject* rende

EPosition position = renderer->style()->position();

bool isFixed = renderer->isOutOfFlowPositioned() && position == FixedPosition;

+ // FIXME: The isStackingContainer check here is redundant. Fixed position elements are always stacking contexts.

if (isFixed && !layer->stackingNode()->isStackingContainer())

return false;

« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »