Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 206463009: Rip out Settings::fixedPositionCreatesStackingContext (Closed)

Created:
6 years, 9 months ago by abarth-chromium
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews, jamesr, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Visibility:
Public.

Description

Rip out Settings::fixedPositionCreatesStackingContext We always turn this setting on. BUG=354688 R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169714

Patch Set 1 #

Patch Set 2 : Update tests #

Patch Set 3 : One more #

Patch Set 4 : Mac baselines #

Patch Set 5 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -157 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/absolute-inside-out-of-view-fixed.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html View 1 1 chunk +1 line, -3 lines 0 comments Download
D LayoutTests/compositing/geometry/fixed-position-composited-switch.html View 1 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/compositing/geometry/fixed-position-composited-switch-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
M LayoutTests/compositing/geometry/limit-layer-bounds-fixed-expected.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/compositing/iframes/fixed-position-element-in-iframe-enters-viewport.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-change-out-of-view-in-view.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-in-view-dynamic.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-dynamic.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/repaint/scroll-fixed-layer-no-content.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/compositing/repaint/scroll-fixed-layer-out-of-view.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/fast/block/positioning/016-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/block/positioning/025-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/block/positioning/fixed-position-stacking-context-expected.png View 1 Binary file 0 comments Download
M LayoutTests/fast/block/positioning/fixed-position-stacking-context-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/block/positioning/fixed-position-stacking-context2.html View 1 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fullscreen/full-screen-fixed-pos-parent.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/platform/win/fast/block/positioning/016-expected.png View 1 Binary file 0 comments Download
M LayoutTests/platform/win/fast/block/positioning/025-expected.png View 1 Binary file 0 comments Download
M LayoutTests/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/CompositedLayerMappingTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSettings.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
abarth-chromium
6 years, 9 months ago (2014-03-20 22:30:35 UTC) #1
ojan
lgtm once you get the layout tests passing.
6 years, 9 months ago (2014-03-20 22:57:33 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 23:10:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206463009/40001
6 years, 9 months ago (2014-03-20 23:10:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 23:44:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-20 23:44:16 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 23:52:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206463009/60001
6 years, 9 months ago (2014-03-20 23:52:14 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 23:53:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-20 23:53:53 UTC) #10
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 00:29:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206463009/80001
6 years, 9 months ago (2014-03-21 00:29:42 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 00:32:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 00:32:33 UTC) #14
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 00:42:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206463009/80001
6 years, 9 months ago (2014-03-21 00:42:05 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 01:03:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-21 01:03:10 UTC) #18
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 01:22:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/206463009/80001
6 years, 9 months ago (2014-03-21 01:22:11 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 02:26:44 UTC) #21
Message was sent while issue was closed. 
Change committed as 169714

Powered by Google App Engine
This is Rietveld 408576698