Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2064613006: Finished small fixups. (Closed)

Created:
4 years, 6 months ago by tlively
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Finished small fixups. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7f0ab86035da401f95a9a255b95d6e5a59bbcbe3

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M Makefile.standalone View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceASanInstrumentation.cpp View 4 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tlively
https://codereview.chromium.org/2064613006/diff/1/src/IceASanInstrumentation.cpp File src/IceASanInstrumentation.cpp (left): https://codereview.chromium.org/2064613006/diff/1/src/IceASanInstrumentation.cpp#oldcode35 src/IceASanInstrumentation.cpp:35: if (BuildDefs::minimal() || DidInsertRedZones) Since the .cpp files are ...
4 years, 6 months ago (2016-06-14 20:12:17 UTC) #2
Jim Stichnoth
lgtm
4 years, 6 months ago (2016-06-14 20:55:37 UTC) #3
tlively
4 years, 6 months ago (2016-06-14 21:06:22 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7f0ab86035da401f95a9a255b95d6e5a59bbcbe3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698