Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: include/v8.h

Issue 20646006: Pipe a script's CORS status through V8 during compilation. (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@master
Patch Set: rebaseline. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 36077402a287046e84cf5f4dc8c1d6bd120a3ab3..ac912343e31439f6b9c28f40dbd4ac6ca6b69583 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -942,17 +942,21 @@ class ScriptOrigin {
V8_INLINE(ScriptOrigin(
Handle<Value> resource_name,
Handle<Integer> resource_line_offset = Handle<Integer>(),
- Handle<Integer> resource_column_offset = Handle<Integer>()))
+ Handle<Integer> resource_column_offset = Handle<Integer>(),
+ Handle<Boolean> resource_passed_access_check = Handle<Boolean>()))
Michael Starzinger 2013/07/30 09:52:55 The term "access check" is already used in the API
Mike West 2013/07/30 10:01:58 The goal is to allow the embedder to determine whe
Mike West 2013/07/30 10:22:43 How about "resource_is_shared_cross_origin" and "S
Michael Starzinger 2013/07/30 10:27:10 Yep, SGTM, I am fine with that.
: resource_name_(resource_name),
resource_line_offset_(resource_line_offset),
- resource_column_offset_(resource_column_offset) { }
+ resource_column_offset_(resource_column_offset),
+ resource_passed_access_check_(resource_passed_access_check) { }
V8_INLINE(Handle<Value> ResourceName() const);
V8_INLINE(Handle<Integer> ResourceLineOffset() const);
V8_INLINE(Handle<Integer> ResourceColumnOffset() const);
+ V8_INLINE(Handle<Boolean> ResourcePassedAccessCheck() const);
private:
Handle<Value> resource_name_;
Handle<Integer> resource_line_offset_;
Handle<Integer> resource_column_offset_;
+ Handle<Boolean> resource_passed_access_check_;
};
@@ -1130,6 +1134,12 @@ class V8EXPORT Message {
*/
int GetEndColumn() const;
+ /**
+ * Returns true if the script in which the exception occurred passed
+ * cross-origin access control checks when originally loaded.
Michael Starzinger 2013/07/30 09:52:55 nit: Can we rephrase the documentation for this me
Mike West 2013/07/30 10:01:58 Will do.
+ */
+ bool DidPassAccessCheck() const;
Michael Starzinger 2013/07/30 09:52:55 nit: In light of the above two comments, could I c
+
// TODO(1245381): Print to a string instead of on a FILE.
static void PrintCurrentStackTrace(FILE* out);
@@ -5976,6 +5986,10 @@ Handle<Integer> ScriptOrigin::ResourceColumnOffset() const {
return resource_column_offset_;
}
+Handle<Boolean> ScriptOrigin::ResourcePassedAccessCheck() const {
+ return resource_passed_access_check_;
+}
+
Handle<Boolean> Boolean::New(bool value) {
return value ? True() : False();
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698