Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2064553002: Revert of Add a trace-event for each runtime-stats timer (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
fmeawad, Camillo Bruni
CC:
nednguyen
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add a trace-event for each runtime-stats timer (patchset #6 id:100001 of https://codereview.chromium.org/2052523002/ ) Reason for revert: Seems to break TSAN, see http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10057 Original issue's description: > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > BUG=v8:5089 > > Committed: https://crrev.com/44ec143f26769bd103662643bfeafc7d0834cc90 > Cr-Commit-Position: refs/heads/master@{#36909} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Committed: https://crrev.com/35f5b3dca4f3d39c7276e456ef76a8fe7036e1cf Cr-Commit-Position: refs/heads/master@{#36910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M src/api.cc View 10 chunks +0 lines, -11 lines 0 comments Download
M src/api-arguments.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/api-arguments-inl.h View 5 chunks +0 lines, -5 lines 0 comments Download
M src/counters.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/tracing/trace-event.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/tracing/trace-event.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of Add a trace-event for each runtime-stats timer
4 years, 6 months ago (2016-06-13 04:19:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064553002/1
4 years, 6 months ago (2016-06-13 04:19:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 04:19:56 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 04:21:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35f5b3dca4f3d39c7276e456ef76a8fe7036e1cf
Cr-Commit-Position: refs/heads/master@{#36910}

Powered by Google App Engine
This is Rietveld 408576698